types(connection+collection): make BaseCollection and BaseConnection usable as values #15575
+22
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasezoey
approved these changes
Aug 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We recently added BaseConnection and BaseCollection in #15548, but that implementation has some oversights. With current implementation, you can't do
class MyCollection extends BaseCollectionbecause BaseCollection is an interface in TypeScript, not a class.It is admittedly a bit strange that we have
BaseConnection extends Connection {}, that's more to derisk breaking anything. In the future, I'd prefer ifBaseConnectioncontained all the Connection definitions and we just hadConnection extends BaseConnection.Examples